-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance tests : - Fix/compare performance with correct branch #66196
Performance tests : - Fix/compare performance with correct branch #66196
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the fix 🙂 I wasn't sure why the performance tests were failing in manual cherry picks like this one: link. |
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: f98cdf7 |
…6196) * Target base branch instead of just trunk * Update description Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
What?
Target Performance tests to base branch instead of just Trunk.
Why?
If
trunk
differs from another base branch, likewp/6.7
, changing for example selectors. Performance tests will fail on all cherry picks to releases branches.Testing Instructions
I'll make this PR to 6.7 to see if performance is being executed there.